From: Jeremy Allison <jra@samba.org>
Date: Fri, 2 Dec 2011 18:55:40 +0000 (-0800)
Subject: Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable... 
X-Git-Tag: tevent-0.9.15~1023
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=46551d750dc58b32630fb6744364fe5a1052b87d;p=samba.git

Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable entries on a directory with no stored ACL.

If referring to an fsp sbuf can be left as an uninitialized variable,
causing the 'is_directory' variable to be false when it should be true.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Dec  2 22:13:03 CET 2011 on sn-devel-104
---

diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 00ac2a19320..bf535c557bd 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -391,7 +391,7 @@ static NTSTATUS get_nt_acl_internal(vfs_handle_struct *handle,
 				return map_nt_error_from_unix(errno);
 			}
 		}
-		is_directory = S_ISDIR(sbuf.st_ex_mode);
+		is_directory = S_ISDIR(psbuf->st_ex_mode);
 
 		if (ignore_file_system_acl) {
 			TALLOC_FREE(pdesc_next);