From: Kamen Mazdrashki <kamenim@samba.org>
Date: Thu, 20 Nov 2014 03:07:47 +0000 (+0100)
Subject: lib-pyldb: Block elements should be surrounded by {} in py_msg.setitem()
X-Git-Tag: tdb-1.3.2~104
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=30c07907749063d0b0c663f1b43b02b4c6b0049d;p=ab%2Fsamba-autobuild%2F.git

lib-pyldb: Block elements should be surrounded by {} in py_msg.setitem()

Change-Id: I0d09374b27708fcaad3523d985a2db7983dbd81a
Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Nov 25 07:24:12 CET 2014 on sn-devel-104
---

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index a9ec6378384..ee751b363e0 100644
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -2863,8 +2863,9 @@ static int py_ldb_msg_setitem(PyLdbMessageObject *self, PyObject *name, PyObject
 		int ret;
 		struct ldb_message_element *el = PyObject_AsMessageElement(self->msg,
 									   value, 0, attr_name);
-		if (el == NULL)
+		if (el == NULL) {
 			return -1;
+		}
 		ldb_msg_remove_attr(pyldb_Message_AsMessage(self), attr_name);
 		ret = ldb_msg_add(pyldb_Message_AsMessage(self), el, el->flags);
 		if (ret != LDB_SUCCESS) {