From: Volker Lendecke <vl@samba.org>
Date: Sat, 18 Sep 2010 14:37:04 +0000 (-0700)
Subject: s3: Fix bug 7688, rpcclient command line completion crashing
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;ds=sidebyside;h=ec3bca61a10d8dcaa6a94046120dd414e39289b1;p=samba.git

s3: Fix bug 7688, rpcclient command line completion crashing

We've grown more than 100 rpcclient commands by now, so this would overwrite
the array of 100 completions. There's nicer ways to fix this problem, but 1000
rpcclient commands should be at least a bit away.
---

diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c
index e24538b8044..f05facb353e 100644
--- a/source3/rpcclient/rpcclient.c
+++ b/source3/rpcclient/rpcclient.c
@@ -49,7 +49,7 @@ handle completion of commands for readline
 ****************************************************************************/
 static char **completion_fn(const char *text, int start, int end)
 {
-#define MAX_COMPLETIONS 100
+#define MAX_COMPLETIONS 1000
 	char **matches;
 	int i, count=0;
 	struct cmd_list *commands = cmd_list;