From: Jeremy Allison Date: Tue, 25 Oct 2011 22:31:48 +0000 (-0700) Subject: Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd process every... X-Git-Url: http://git.samba.org/?a=commitdiff_plain;ds=sidebyside;h=0f746fcad83350afe3168036cb084b86cd286e85;p=kai%2Fsamba.git Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while. Don't just use the first entry in back_channels as a talloc context to allocate a long-lived chan entry on - must be NULL. It's already correctly deleted when the last reference goes away. Autobuild-User: Jeremy Allison Autobuild-Date: Wed Oct 26 02:42:35 CEST 2011 on sn-devel-104 --- diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index 2efd8823cff..3405566ed76 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -2613,7 +2613,7 @@ static bool srv_spoolss_replyopenprinter(int snum, const char *printer, /* the +2 is to strip the leading 2 backslashs */ fstrcpy(unix_printer, printer + 2); - chan = talloc_zero(back_channels, struct notify_back_channel); + chan = talloc_zero(NULL, struct notify_back_channel); if (!chan) { return false; }