]> git.samba.org - samba.git/commitdiff
auth/credentials: Check NTSTATUS return from netlogon_creds_aes_encrypt()
authorAndrew Bartlett <abartlet@samba.org>
Fri, 16 Aug 2019 02:29:45 +0000 (14:29 +1200)
committerAndreas Schneider <asn@cryptomilk.org>
Wed, 21 Aug 2019 09:57:30 +0000 (09:57 +0000)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
auth/credentials/credentials.c

index 5ebec483705e548069a3acea824cbb6cfed1583a..81f9dbb9eb3a6aafb70bf1c69bd80f0280e26899 100644 (file)
@@ -1333,19 +1333,19 @@ _PUBLIC_ NTSTATUS netlogon_creds_session_encrypt(
                return NT_STATUS_INVALID_PARAMETER;
        }
        if (state->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
-               netlogon_creds_aes_encrypt(state,
-                                          data.data,
-                                          data.length);
+               status = netlogon_creds_aes_encrypt(state,
+                                                   data.data,
+                                                   data.length);
        } else if (state->negotiate_flags & NETLOGON_NEG_ARCFOUR) {
                status = netlogon_creds_arcfour_crypt(state,
                                                      data.data,
                                                      data.length);
-               if (!NT_STATUS_IS_OK(status)) {
-                       return status;
-               }
        } else {
                DBG_ERR("Unsupported encryption option negotiated");
-               return NT_STATUS_NOT_SUPPORTED;
+               status = NT_STATUS_NOT_SUPPORTED;
+       }
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
        return NT_STATUS_OK;
 }