Very curious. It turns out attribute matching on truncate only matters

when opening truncate with current SYSTEM|HIDDEN -> NONE. It's fine to
truncate on open with current NONE -> SYSTEM | HIDDEN.
Jeremy.
(This used to be commit 3bf21ca936973efcd74b826bc750131c6ab2c701)

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 94a705e6b63c09215a8252536730160733ea4e0b..cee2b37184917ab1d43e2f3a8ea724f68ee279d5 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -712,11 +712,11 @@ static BOOL open_match_attributes(connection_struct *conn, char *path, mode_t ex
 
        /* If we're mapping SYSTEM and HIDDEN ensure they match. */
        if (lp_map_system(SNUM(conn))) {
-               if ((old_dos_mode & FILE_ATTRIBUTE_SYSTEM) != (new_dos_mode & FILE_ATTRIBUTE_SYSTEM))
+               if ((old_dos_mode & FILE_ATTRIBUTE_SYSTEM) && !(new_dos_mode & FILE_ATTRIBUTE_SYSTEM))
                        return False;
        }
        if (lp_map_hidden(SNUM(conn))) {
-               if ((old_dos_mode & FILE_ATTRIBUTE_HIDDEN) != (new_dos_mode & FILE_ATTRIBUTE_HIDDEN))
+               if ((old_dos_mode & FILE_ATTRIBUTE_HIDDEN) && !(new_dos_mode & FILE_ATTRIBUTE_HIDDEN))
                        return False;
        }
        return True;