selftest: split a large system invocation line
authorRalph Boehme <slow@samba.org>
Tue, 9 Jan 2018 09:45:59 +0000 (10:45 +0100)
committerRalph Boehme <slow@samba.org>
Wed, 10 Jan 2018 00:01:25 +0000 (01:01 +0100)
Small cleanup for better code readability, no change in behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
selftest/target/Samba3.pm

index 73ac1c3a17e424a211fe83dacf76421d7780aa3e..17247274b734acf51504b734063b60f25ba32a6c 100755 (executable)
@@ -2463,7 +2463,11 @@ sub wait_for_start($$$$$)
                teardown_env($self, $envvars);
                return 0;
            }
-           system(Samba::bindir_path($self, "net") . " $envvars->{CONFIGURATION} cache del IDMAP/SID2XID/S-1-5-32-545");
+
+           $cmd = Samba::bindir_path($self, "net") . " $envvars->{CONFIGURATION} ";
+           $cmd .= "cache del IDMAP/SID2XID/S-1-5-32-545";
+           system($cmd);
+
            $ret = system("SELFTEST_WINBINDD_SOCKET_DIR=" . $envvars->{SELFTEST_WINBINDD_SOCKET_DIR} . " " . Samba::bindir_path($self, "wbinfo") . " --sid-to-gid=S-1-5-32-545");
            if ($ret != 0) {
                print "Missing \"BUILTIN\\Users\", did net sam createbuiltingroup Users fail?\n";