We should report if a group mapping fails. This should fix bug#225.

Jerry, this is assigned to you. Do you want to answer it?

However, we have to decide what to do if a mapping is to be done for a
unix group not in LDAP....

Volker
(This used to be commit bf449d467cfe4987df17010490a16ab0472c0803)

diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c
index 8a6f5148605998b9474cf124b258b99e1893ffbf..951361f4d4158f2c34f4587474dbd72d5f1e6d8a 100644 (file)
--- a/source3/groupdb/mapping.c
+++ b/source3/groupdb/mapping.c
@@ -222,9 +222,7 @@ BOOL add_initial_entry(gid_t gid, const char *sid, enum SID_NAME_USE sid_name_us
        fstrcpy(map.nt_name, nt_name);
        fstrcpy(map.comment, comment);
 
-       pdb_add_group_mapping_entry(&map);
-
-       return True;
+       return pdb_add_group_mapping_entry(&map);
 }
 
 /****************************************************************************