git.samba.org
/
obnox
/
samba
/
samba-obnox.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f1781ad
)
tevent: Fix Coverity ID 989236 Operands don't affect result
author
Volker Lendecke
<vl@samba.org>
Thu, 13 Jun 2013 18:35:32 +0000
(20:35 +0200)
committer
Jeremy Allison
<jra@samba.org>
Fri, 14 Jun 2013 16:31:39 +0000
(09:31 -0700)
"unsigned" could be less than uint64_t, so idx==UINT64_MAX is always false.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib/tevent/tevent_poll.c
patch
|
blob
|
history
diff --git
a/lib/tevent/tevent_poll.c
b/lib/tevent/tevent_poll.c
index c6e2a00ffec6393fd6fccc1a3836f63e4ef4e045..75d0ced5a09ea86505a5df49b3c84073d3aa0f02 100644
(file)
--- a/
lib/tevent/tevent_poll.c
+++ b/
lib/tevent/tevent_poll.c
@@
-546,7
+546,7
@@
static int poll_event_loop_poll(struct tevent_context *ev,
the handler to remove itself when called */
for (fde = ev->fd_events; fde; fde = fde->next) {
- u
nsigned
idx = fde->additional_flags;
+ u
int64_t
idx = fde->additional_flags;
struct pollfd *pfd;
uint16_t flags = 0;