git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
2b48789
)
libsmb: Remove overflow check
author
Joseph Sutton
<josephsutton@catalyst.net.nz>
Mon, 3 May 2021 03:55:01 +0000
(15:55 +1200)
committer
Jeremy Allison
<jra@samba.org>
Wed, 19 May 2021 01:32:34 +0000
(
01:32
+0000)
Pointer overflow is undefined, so this check does not accomplish
anything.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
source3/libsmb/clifsinfo.c
patch
|
blob
|
history
diff --git
a/source3/libsmb/clifsinfo.c
b/source3/libsmb/clifsinfo.c
index a9b3b03abb698f69c1380c1cbef1d552091e749f..135a77f2312322714d8233cf2cbdca55bc086143 100644
(file)
--- a/
source3/libsmb/clifsinfo.c
+++ b/
source3/libsmb/clifsinfo.c
@@
-650,7
+650,7
@@
static void cli_posix_whoami_done(struct tevent_req *subreq)
* parsing network packets in C.
*/
- if (num_rdata < 40
|| rdata + num_rdata < rdata
) {
+ if (num_rdata < 40) {
tevent_req_nterror(req, NT_STATUS_INVALID_NETWORK_RESPONSE);
return;
}