recoverd: Really fix bogus info in message about changed flags
authorMartin Schwenke <martin@meltin.net>
Thu, 11 Jul 2013 03:01:13 +0000 (13:01 +1000)
committerAmitay Isaacs <amitay@gmail.com>
Thu, 11 Jul 2013 05:18:06 +0000 (15:18 +1000)
Commit 9119a568c2b4601318f7751f537dca2f92a7230b attempted to fix this.
However, this was wrong because old_flags and new_flags were confused.
The latter has since been fixed in commit
7eb2f89979360b6cc98ca9b17c48310277fa89fc so this can now be fixed
properly.

Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 40f2825d6e818dc8c745b6385a545969dfb45fbc)

ctdb/server/ctdb_recoverd.c

index 935873414372cebf17082de437c22919e2ab06cf..bf8d8cc960a5797caec1639ca0d9139c00427324 100644 (file)
@@ -2619,8 +2619,8 @@ static void monitor_handler(struct ctdb_context *ctdb, uint64_t srvid,
                return;
        }
 
-       if (nodemap->nodes[i].flags != c->new_flags) {
-               DEBUG(DEBUG_NOTICE,("Node %u has changed flags - now 0x%x  was 0x%x\n", c->pnn, c->new_flags, nodemap->nodes[i].flags));
+       if (c->old_flags != c->new_flags) {
+               DEBUG(DEBUG_NOTICE,("Node %u has changed flags - now 0x%x  was 0x%x\n", c->pnn, c->new_flags, c->old_flags));
        }
 
        disabled_flag_changed =  (nodemap->nodes[i].flags ^ c->new_flags) & NODE_FLAGS_DISABLED;