s3:idmap: only check the range values if a range setting has been found.
authorMichael Adam <obnox@samba.org>
Sun, 20 Jul 2014 10:12:16 +0000 (12:12 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 25 Jul 2014 09:52:10 +0000 (11:52 +0200)
Otherwise, the check is superfluous since high and low values are
initialized to 0.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
source3/winbindd/idmap.c

index e62f477764d60f8ad369ff0a42e5fc660ea2bb47..dc972fea00eae8806367e26101d380703f8db23e 100644 (file)
@@ -238,9 +238,7 @@ static struct idmap_domain *idmap_init_domain(TALLOC_CTX *mem_ctx,
                if (check_range) {
                        goto fail;
                }
-       }
-
-       if (result->low_id > result->high_id) {
+       } else if (result->low_id > result->high_id) {
                DEBUG(1, ("Error: invalid idmap range detected: %lu - %lu\n",
                          (unsigned long)result->low_id,
                          (unsigned long)result->high_id));