r10346: here are only real ip-addresses valid, prevent dns lookups,

when the input is invalid

metze
(This used to be commit 1083204c1f89d9b918015113b6cc2ea423372fe0)

diff --git a/source4/librpc/ndr/ndr_basic.c b/source4/librpc/ndr/ndr_basic.c
index 4d3ac2c774ee2638be4fe1aa6be16eac0f3b1068..e559ea8ff63db75c305e22d22e7841cb4fe8620c 100644 (file)
--- a/source4/librpc/ndr/ndr_basic.c
+++ b/source4/librpc/ndr/ndr_basic.c
@@ -569,7 +569,9 @@ NTSTATUS ndr_pull_ipv4address(struct ndr_pull *ndr, int ndr_flags, const char **
 */
 NTSTATUS ndr_push_ipv4address(struct ndr_push *ndr, int ndr_flags, const char *address)
 {
-       uint32_t addr = interpret_addr(address);
+       uint32_t addr;
+       if (!is_ipaddress(address)) return NT_STATUS_INVALID_PARAMETER_MIX;
+       addr = sys_inet_addr(address);
        NDR_CHECK(ndr_push_uint32(ndr, ndr_flags, htonl(addr)));
        return NT_STATUS_OK;
 }