KCC: remove another needless loop variable
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 27 Mar 2015 05:10:34 +0000 (18:10 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 29 May 2015 09:08:21 +0000 (11:08 +0200)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/scripting/bin/samba_kcc

index 0a5268fca353f139f526337d0fccc29056f6fd49..01d4cb725353528210f57a7f78092df4d4a0e68c 100755 (executable)
@@ -913,7 +913,8 @@ class KCC(object):
             n_rep.load_fsmo_roles(self.samdb)
 
             # Loop thru the existing repsFrom tupples (if any)
-            for i, t_repsFrom in enumerate(n_rep.rep_repsFrom):
+            # XXX This is a list and could contain duplicates (multiple load_repsFrom calls)
+            for t_repsFrom in n_rep.rep_repsFrom:
 
                 # for each tuple t in n!repsFrom, let s be the nTDSDSA
                 # object such that s!objectGUID = t.uuidDsa