ieee80211: Correct the actual bit positions of the reserved bits.
authorRichard Sharpe <realrichardsharpe@gmail.com>
Mon, 12 Feb 2018 16:54:49 +0000 (08:54 -0800)
committerAnders Broman <a.broman58@gmail.com>
Tue, 13 Feb 2018 20:35:10 +0000 (20:35 +0000)
The reserved bit positions should match the bit positions of the fields
that are reserved. Also, the hf_he_srg_information_present bit was nibble
reversed.

Errors found by George Baltatanu.

Change-Id: I218ff9aa7bdabc4ec6e470c3ef1be230ce341b34
Reviewed-on: https://code.wireshark.org/review/25760
Reviewed-by: Anders Broman <a.broman58@gmail.com>
epan/dissectors/packet-ieee80211.c

index 656130d7af3b0eac94f2eb653dedc7f92b299235..03350fd03d1ecb6110daa10fdeae5072c36442df 100644 (file)
@@ -30227,11 +30227,11 @@ proto_register_ieee80211(void)
 
     {&hf_he_reserved_bit_18,
      {"Reserved", "wlan.ext_tag.he_mac_cap.reserved_bit_18",
-      FT_UINT40, BASE_HEX, NULL, 0x0000000400, NULL, HFILL }},
+      FT_UINT40, BASE_HEX, NULL, 0x0000040000, NULL, HFILL }},
 
     {&hf_he_reserved_bit_19,
      {"Reserved", "wlan.ext_tag.he_mac_cap.reserved_bit_19",
-      FT_UINT40, BASE_HEX, NULL, 0x0000000800, NULL, HFILL }},
+      FT_UINT40, BASE_HEX, NULL, 0x0000080000, NULL, HFILL }},
 
     {&hf_he_reserved_bit_25,
      {"Reserved", "wlan.ext_tag.he_mac_cap.reserved_bit_25",
@@ -30686,7 +30686,7 @@ proto_register_ieee80211(void)
 
     {&hf_he_srg_information_present,
      {"SRG Information Present", "wlan.ext_tag.spatial_reuse.sr_control.srg_info_present",
-     FT_BOOLEAN, 8, NULL, 0x80, NULL, HFILL }},
+     FT_BOOLEAN, 8, NULL, 0x08, NULL, HFILL }},
 
     {&hf_he_hesiga_spatial_reuse_value15_allowed,
      {"HESIGA Spatial Reuse value 15 allowed", "wlan.ext_tag.spatial_reuse.sr_control.hesiga_val_15_allowed",