Why? This makes the negative mapping condition (is_null_sid) more
explicit in the code.
The callers in lookup_sid initialized "psid" anyway before, and the ones
in wb_xids2sids now do as well. This is more in line with other APIs we
have: Only touch output parameters if you have something to say.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
(cherry picked from commit
4faf3e9f6da7515fc263d79f77226d105c2f8524)
(struct idmap_cache_xid2sid_state *)private_data;
char *value;
- ZERO_STRUCTP(state->sid);
- state->ret = false;
-
if ((blob.length == 0) || (blob.data[blob.length-1] != 0)) {
/*
* Not a string, can't be a valid mapping
*/
+ state->ret = false;
return;
}
/*
* Return NULL SID, see comment to uid2sid
*/
+ *state->sid = (struct dom_sid) {0};
state->ret = true;
} else {
state->ret = string_to_sid(state->sid, value);
uint32_t i;
for (i=0; i<num_xids; i++) {
- struct dom_sid sid;
+ struct dom_sid sid = {0};
bool ok, expired;
switch (xids[i].type) {