git.samba.org
/
obnox
/
samba
/
samba-obnox.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4199976
)
s4-process_model Fix valgrind-found use of un-initialised variable
author
Andrew Bartlett
<abartlet@samba.org>
Tue, 2 Nov 2010 09:55:18 +0000
(20:55 +1100)
committer
Andrew Bartlett
<abartlet@samba.org>
Tue, 2 Nov 2010 11:00:54 +0000
(22:00 +1100)
The relloc didn't zero the structure for the new process modal, and so
m->initialised wasn't initialised.
Andrew Bartlett
source4/smbd/process_model.c
patch
|
blob
|
history
diff --git
a/source4/smbd/process_model.c
b/source4/smbd/process_model.c
index 1696163f990cc06c09bf1aee4193f0214ef77aa7..7b18f583a7179d29e92256b8a9712026b1ab03ac 100644
(file)
--- a/
source4/smbd/process_model.c
+++ b/
source4/smbd/process_model.c
@@
-92,6
+92,7
@@
_PUBLIC_ NTSTATUS register_process_model(const void *_ops)
models[num_models].ops = smb_xmemdup(ops, sizeof(*ops));
models[num_models].ops->name = smb_xstrdup(ops->name);
+ models[num_models].initialised = false;
num_models++;