Revert "Get rid of HAVE_REMOTE."

This reverts commit d13b8ea13cf708a7770e7f51912ce16d0b43e459.

This will only work with git HEAD of libpcap, but not with any release versions of libpcap or winpcap (the *pcap includes require the define, not Wireshark).

Change-Id: I08e5ec66e3642dc02f793c83ffc4363bb348202c
Reviewed-on: https://code.wireshark.org/review/21603
Reviewed-by: Jörg Mayer <jmayer@loplof.de>

diff --git a/acinclude.m4 b/acinclude.m4
index fcbbab8327981e3b13f750bd4aec623097a2cd52..11c657fd8704736c98ea953e887bb7a01553daf9 100644 (file)
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -423,10 +423,12 @@ AC_DEFUN([AC_WIRESHARK_PCAP_REMOTE_CHECK],
 [
     ac_save_LIBS="$LIBS"
     LIBS="$PCAP_LIBS $LIBS"
+    AC_DEFINE(HAVE_REMOTE, 1, [Define to 1 to enable remote
+              capturing feature in WinPcap library])
     AC_CHECK_FUNCS(pcap_open)
     if test $ac_cv_func_pcap_open = "yes" ; then
         AC_DEFINE(HAVE_PCAP_REMOTE, 1,
-            [Define to 1 if you have libpcap/WinPcap remote capturing support and prefer to use these new API features.])
+            [Define to 1 if you have WinPcap remote capturing support and prefer to use these new API features.])
     fi
     AC_CHECK_FUNCS(pcap_setsampling)
     LIBS="$ac_save_LIBS"

diff --git a/cmake/modules/FindPCAP.cmake b/cmake/modules/FindPCAP.cmake
index 508d46b3a751ced1538d6a072de81865826086de..85053abff47533cf58c243f2a2bc5da7de5da3cc 100644 (file)
--- a/cmake/modules/FindPCAP.cmake
+++ b/cmake/modules/FindPCAP.cmake
@@ -89,6 +89,7 @@ if( PCAP_FOUND )
   check_function_exists( "pcap_open" HAVE_PCAP_OPEN )
   if( HAVE_PCAP_OPEN )
     set( HAVE_PCAP_REMOTE 1 )
+    set( HAVE_REMOTE 1 )
   endif()
 
   cmake_pop_check_state()

diff --git a/cmakeconfig.h.in b/cmakeconfig.h.in
index cfb01047c0797095ccf3c60906c58c3439efe3e0..043c6ada089f09ae0384661bf912e1984f117924 100644 (file)
--- a/cmakeconfig.h.in
+++ b/cmakeconfig.h.in
@@ -266,7 +266,8 @@
 /* Define to 1 if you have the `pcap_open_dead' function. */
 #cmakedefine HAVE_PCAP_OPEN_DEAD 1
 
-/* Define to 1 if you have libpcap/WinPcap remote capturing support. */
+/* Define to 1 if you have WinPcap remote capturing support and prefer to use
+   these new API features. */
 #cmakedefine HAVE_PCAP_REMOTE 1
 
 /* Define to 1 if you have the `pcap_set_datalink' function. */
@@ -290,6 +291,9 @@
 /* Define to 1 if you have the optreset variable */
 #cmakedefine HAVE_OPTRESET 1
 
+/* Define to 1 to enable remote capturing feature in WinPcap library */
+#cmakedefine HAVE_REMOTE 1
+
 /* Define if sa_len field exists in struct sockaddr */
 #cmakedefine HAVE_STRUCT_SOCKADDR_SA_LEN 1