Fix a couple of shellcheck issues.
authorGerald Combs <gerald@wireshark.org>
Tue, 25 Jun 2019 15:09:54 +0000 (08:09 -0700)
committerGerald Combs <gerald@wireshark.org>
Tue, 25 Jun 2019 15:13:51 +0000 (15:13 +0000)
Change-Id: Iaebbe5227ffcc581e794a3be1f8b9020fd600f68
Reviewed-on: https://code.wireshark.org/review/33739
Reviewed-by: Gerald Combs <gerald@wireshark.org>
image/stock_icons/svg-to-png.sh
packaging/macosx/osx-app.sh.in

index 60389bf60bb882af5dec921ed110593f82c7ffcc..e37c503e89daf900783bface8f3b2766621b9eb0 100755 (executable)
@@ -13,7 +13,7 @@
 
 COMMON_ARGS="--export-area-page"
 
-SVGCLEANER=$( type -p svgcleaner )
+#SVGCLEANER=$( type -p svgcleaner )
 
 set_source_svgs() {
     local out_icon=$1
index 73ec0f6736ebd9c8702d50a585365382aeba5e9b..86fd93e1a599bf1fd8894c0a01e37e26a86015e0 100755 (executable)
@@ -372,7 +372,7 @@ rpathify_dir () {
                #
                # shellcheck disable=SC2086
                files=$( ls $2 2>/dev/null )
-               if [ ! -z "$files" ]; then
+               if [ -n "$files" ]; then
                        for file in $files; do
                                rpathify_file "$file" "$( pwd )"
                        done