s4:dcesrv_samr_GetGroupsForUser - return error code if a SID wasn't found
authorMatthias Dieter Wallnöfer <mdw@samba.org>
Sat, 12 Jun 2010 15:50:52 +0000 (17:50 +0200)
committerMatthias Dieter Wallnöfer <mdw@samba.org>
Sat, 12 Jun 2010 15:50:52 +0000 (17:50 +0200)
This shouldn't happen since SIDs are mandatory for security objects

source4/rpc_server/samr/dcesrv_samr.c

index c11caee877c454cb24f3a8e402c65f4436eaef16..9aab2b8b4382e88dfdd99503301387445dfb0541 100644 (file)
@@ -3418,8 +3418,7 @@ static NTSTATUS dcesrv_samr_GetGroupsForUser(struct dcesrv_call_state *dce_call,
 
                group_sid = samdb_result_dom_sid(mem_ctx, res[i], "objectSid");
                if (group_sid == NULL) {
-                       DEBUG(0, ("Couldn't find objectSid attrib\n"));
-                       continue;
+                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
 
                array->rids[i + 1].rid =