git.samba.org
/
obnox
/
samba
/
samba-obnox.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
85f128e
)
s3-spoolss: Consistently fail OpenPrinterEx with "" printername
author
Andrew Bartlett
<abartlet@samba.org>
Tue, 13 Mar 2012 10:59:32 +0000
(21:59 +1100)
committer
Günther Deschner
<gd@samba.org>
Tue, 13 Mar 2012 16:50:59 +0000
(17:50 +0100)
samba3.rpc.spoolss.printserver has become a flakey test recently, and this
papers over the real problem.
Andrew Bartlett
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 13 17:51:00 CET 2012 on sn-devel-104
source3/rpc_server/spoolss/srv_spoolss_nt.c
patch
|
blob
|
history
diff --git
a/source3/rpc_server/spoolss/srv_spoolss_nt.c
b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index f66bea8197ceb4802e5cc5f1fdc30075cbaa7045..daed9906fdc530a25763590a65c0eb290eaf7655 100644
(file)
--- a/
source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/
source3/rpc_server/spoolss/srv_spoolss_nt.c
@@
-1710,6
+1710,10
@@
WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p,
return WERR_INVALID_PARAM;
}
+ if (!*r->in.printername) {
+ return WERR_INVALID_PARAM;
+ }
+
if (r->in.level > 3) {
return WERR_INVALID_PARAM;
}