git.samba.org
/
mat
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7d96a45
)
s3: Fix Coverity ID 2586 -- NO_EFFECT
author
Volker Lendecke
<vl@samba.org>
Wed, 6 Jul 2011 07:37:04 +0000
(09:37 +0200)
committer
Volker Lendecke
<vl@samba.org>
Wed, 6 Jul 2011 07:50:02 +0000
(09:50 +0200)
tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is
unsigned. So (len < 0) could never have turned true.
Volker
source3/lib/util_sock.c
patch
|
blob
|
history
diff --git
a/source3/lib/util_sock.c
b/source3/lib/util_sock.c
index a35bd58d11d415e77b943a57ff725ef15e39b174..5154a83fecf05fa57733cf326a18eae8e0d93191 100644
(file)
--- a/
source3/lib/util_sock.c
+++ b/
source3/lib/util_sock.c
@@
-1135,7
+1135,7
@@
int get_remote_hostname(const struct tsocket_address *remote_address,
char tmp_name[MAX_DNS_NAME_LENGTH];
struct name_addr_pair nc;
struct sockaddr_storage ss;
- s
ocklen
_t len;
+ s
size
_t len;
int rc;
if (!lp_hostname_lookups()) {