smbd: tweak POSIX check in smbd_do_qfilepathinfo()
authorRalph Boehme <slow@samba.org>
Mon, 13 Nov 2023 09:36:14 +0000 (10:36 +0100)
committerJeremy Allison <jra@samba.org>
Mon, 27 Nov 2023 18:31:35 +0000 (18:31 +0000)
This check is only needed for SMB2, so check for that, and in the SMB2 codepath
we'll always have a valid fsp, so we can drop that check.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/smb2_trans2.c

index 5ed2d9ffcac0c2ed2aad5f71e23b89875c3fe2fa..3d13d05673b5878a11ababf571b706af9b549e0e 100644 (file)
@@ -3000,8 +3000,9 @@ NTSTATUS smbd_do_qfilepathinfo(connection_struct *conn,
                        ok = true;
                }
 
-               if ((fsp != NULL) &&
-                   (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN)) {
+               if (conn->sconn->using_smb2 &&
+                   (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN))
+               {
                        DBG_DEBUG("SMB2 posix open\n");
                        ok = true;
                }