s4:ntvfs: Do not free eadb before we printed an error

Found by GCC 9.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source4/ntvfs/posix/vfs_posix.c b/source4/ntvfs/posix/vfs_posix.c
index df5637486d38acd86bef0681f1c26daac0027890..c69e979c31c9165ab2eb6726723cd43332931b00 100644 (file)
--- a/source4/ntvfs/posix/vfs_posix.c
+++ b/source4/ntvfs/posix/vfs_posix.c
@@ -123,7 +123,6 @@ static void pvfs_setup_options(struct pvfs_state *pvfs)
                        pvfs, eadb, 50000,
                        lpcfg_tdb_flags(pvfs->ntvfs->ctx->lp_ctx, TDB_DEFAULT),
                        O_RDWR|O_CREAT, 0600);
-               TALLOC_FREE(eadb);
                if (pvfs->ea_db != NULL) {
                        pvfs->flags |= PVFS_FLAG_XATTR_ENABLE;
                } else {
@@ -131,6 +130,7 @@ static void pvfs_setup_options(struct pvfs_state *pvfs)
                                 eadb, strerror(errno)));
                        pvfs->flags &= ~PVFS_FLAG_XATTR_ENABLE;
                }
+               TALLOC_FREE(eadb);
        }
 
        if (pvfs->flags & PVFS_FLAG_XATTR_ENABLE) {