Fix comment.
authorJoão Valverde <joao.valverde@tecnico.ulisboa.pt>
Tue, 21 Aug 2018 22:44:12 +0000 (23:44 +0100)
committerJoão Valverde <j@v6e.pt>
Tue, 21 Aug 2018 23:11:04 +0000 (23:11 +0000)
Change-Id: Ib41b9a84333a3d3d34ae9c0797dbae10141f9e53
Reviewed-on: https://code.wireshark.org/review/29235
Reviewed-by: João Valverde <j@v6e.pt>
doc/plugins.example/CMakeLists.txt

index d754fc4cf3a1df204ce0b5d8405e35674dbf0be2..23a7e8f713ea9ae4c1f8e4e5364f8291e6f80aff 100644 (file)
@@ -17,9 +17,8 @@ find_package(PkgConfig REQUIRED)
 pkg_check_modules(WIRESHARK REQUIRED wireshark>=2.5)
 ### CMake Bug: Use PKG_CONFIG_PATH instead of CMAKE_PREFIX_PATH
 # https://gitlab.kitware.com/cmake/cmake/issues/15805
-### CMake Bug: If you run into problems please use the "Unix Makefiles" generator.
-### Ninja just wipes the pkg-config variables.
-# https://gitlab.kitware.com/cmake/cmake/issues/17531 (and probably others)
+# Note: If using PKG_CONFIG_PATH the variable needs to be set as exported
+# in the execution environment.
 pkg_get_variable(WIRESHARK_PLUGIN_DIR wireshark plugindir)
 
 set(PLUGIN_INSTALL_LIBDIR "${WIRESHARK_PLUGIN_DIR}/epan")