This should really be a cond_set_smb_read_error().

Jeremy.
(This used to be commit 5ab76b58c00dde89b56060482f5cdc5d0c6c56cb)

diff --git a/source3/lib/util_sock.c b/source3/lib/util_sock.c
index ea0bf281add707c56c547363c52f5a4486151898..d87d954536444932be1e80afd07bc25bb61c62e3 100644 (file)
--- a/source3/lib/util_sock.c
+++ b/source3/lib/util_sock.c
@@ -1276,9 +1276,7 @@ bool receive_smb(int fd, char *buffer, unsigned int timeout)
        if (!srv_check_sign_mac(buffer, true)) {
                DEBUG(0, ("receive_smb: SMB Signature verification "
                        "failed on incoming packet!\n"));
-               if (get_smb_read_error() == SMB_READ_OK) {
-                       smb_read_error = SMB_READ_BAD_SIG;
-               }
+               cond_set_smb_read_error(SMB_READ_BAD_SIG);
                return false;
        }