python/ms_forest_updates_markdown: avoid implicit global variable
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sat, 27 Oct 2018 21:37:51 +0000 (10:37 +1300)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 17 Jul 2020 07:17:39 +0000 (07:17 +0000)
out_dict would have been shared across all calls, aggregating values as it went.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Mulder <dmulder@samba.org>
python/samba/ms_forest_updates_markdown.py

index 26cc3fd776a23a7c3d26a53a22d2f9fed94d7e35..62e9ad9b3546e93f7a57ca76941196bcca4cecd5 100644 (file)
@@ -195,7 +195,7 @@ def innertext(tag):
         (tag.tail or '')
 
 
-def read_ms_markdown(in_file, out_folder=None, out_dict={}):
+def read_ms_markdown(in_file, out_folder=None, out_dict=None):
     """
     Read Github documentation to produce forest wide udpates
     :param in_file: Forest-Wide-Updates.md