s3-printing: Fix double free of cups request.
authorGünther Deschner <gd@samba.org>
Tue, 10 May 2011 13:49:05 +0000 (15:49 +0200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 17 May 2011 07:06:41 +0000 (09:06 +0200)
We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):

"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."

Revert "Fix a memory leak in cups_pull_comment_location"

This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632.

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
(cherry picked from commit 019f11dd5b3240d05c1abe30dec3d793d6919313)

source3/printing/print_cups.c

index f06a797c4389128d1e71d7538d91cbe4190b920d..b41cd34c42d73dfd065df45ffc5be8cc81d30837 100644 (file)
@@ -1796,10 +1796,6 @@ bool cups_pull_comment_location(NT_PRINTER_INFO_LEVEL_2 *printer)
        if (response)
                ippDelete(response);
 
-       if (request) {
-               ippDelete(request);
-       }
-
        if (language)
                cupsLangFree(language);