lib/util/asn1: let asn1_peek_full_tag() return an error if we fail to parse tag hdr/len

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Oct  4 14:46:40 UTC 2010 on sn-devel-104

diff --git a/lib/util/asn1.c b/lib/util/asn1.c
index 7e37fbc91bd42d20f66662c9c560d20750c159e5..7635ce2d8835ab5e47e72c35d9ef738a11df78bf 100644 (file)
--- a/lib/util/asn1.c
+++ b/lib/util/asn1.c
@@ -527,6 +527,18 @@ bool asn1_peek_tag_needed_size(struct asn1_data *data, uint8_t tag, size_t *size
                        data->has_error = false;
                        return false;
                }
+               if (n > 4) {
+                       /*
+                        * We should not allow more than 4 bytes
+                        * for the encoding of the tag length.
+                        *
+                        * Otherwise we'd overflow the taglen
+                        * variable on 32 bit systems.
+                        */
+                       data->ofs = start_ofs;
+                       data->has_error = false;
+                       return false;
+               }
                taglen = b;
                while (n > 1) {
                        if (!asn1_read_uint8(data, &b)) {
@@ -1020,7 +1032,7 @@ NTSTATUS asn1_peek_full_tag(DATA_BLOB blob, uint8_t tag, size_t *packet_size)
 
        ok = asn1_peek_tag_needed_size(&asn1, tag, &size);
        if (!ok) {
-               return STATUS_MORE_ENTRIES;
+               return NT_STATUS_INVALID_BUFFER_SIZE;
        }
 
        if (size > blob.length) {