s3-auth: Fix valgrind warning (unitialized var) in samu_to_SamInfo3().

Guenther

s3:auth do not fail if there are 0 group sids

Signed-off-by: Günther Deschner <gd@samba.org>

diff --git a/source3/auth/server_info.c b/source3/auth/server_info.c
index 1ef272489cbf94f099931c74ec79937d4af7a309..a43c4f931a88a413c0f8816440f1e16a81e53c7a 100644 (file)
--- a/source3/auth/server_info.c
+++ b/source3/auth/server_info.c
@@ -308,7 +308,7 @@ NTSTATUS samu_to_SamInfo3(TALLOC_CTX *mem_ctx,
        const struct dom_sid *group_sid;
        struct dom_sid domain_sid;
        struct dom_sid *group_sids;
-       size_t num_group_sids;
+       size_t num_group_sids = 0;
        const char *tmp;
        gid_t *gids;
        NTSTATUS status;
@@ -441,10 +441,12 @@ NTSTATUS samu_to_SamInfo3(TALLOC_CTX *mem_ctx,
                return status;
        }
 
-       status = group_sids_to_info3(info3, group_sids, num_group_sids);
-       if (!NT_STATUS_IS_OK(status)) {
-               TALLOC_FREE(info3);
-               return status;
+       if (num_group_sids) {
+               status = group_sids_to_info3(info3, group_sids, num_group_sids);
+               if (!NT_STATUS_IS_OK(status)) {
+                       TALLOC_FREE(info3);
+                       return status;
+               }
        }
 
        /* We don't need sids and gids after the conversion */