s4:libcli/smb2: use talloc_zero() in smb2_request_init()
authorStefan Metzmacher <metze@samba.org>
Sat, 24 Sep 2011 07:36:58 +0000 (09:36 +0200)
committerStefan Metzmacher <metze@samba.org>
Thu, 24 Nov 2011 18:02:33 +0000 (19:02 +0100)
metze

source4/libcli/smb2/request.c

index a2d633f8555663b95f11caea45272184146f18eb..2fcc3813143582c1af638a6166d0f0299cae3c6a 100644 (file)
@@ -61,26 +61,13 @@ struct smb2_request *smb2_request_init(struct smb2_transport *transport, uint16_
                body_dynamic_size = 0;
        }
 
-       req = talloc(transport, struct smb2_request);
+       req = talloc_zero(transport, struct smb2_request);
        if (req == NULL) return NULL;
 
        req->state     = SMB2_REQUEST_INIT;
        req->transport = transport;
-       req->session   = NULL;
-       req->tree      = NULL;
-       req->recv_iov  = NULL;
-       req->status    = NT_STATUS_OK;
-       req->async.fn  = NULL;
-
-       ZERO_STRUCT(req->cancel);
-       ZERO_STRUCT(req->in);
-       ZERO_STRUCT(req->out);
-
-       if (req->out.size > 0) {
-               hdr_offset = req->out.size;
-       } else {
-               hdr_offset = NBT_HDR_SIZE;
-       }
+
+       hdr_offset = NBT_HDR_SIZE;
 
        req->out.size      = hdr_offset + SMB2_HDR_BODY + body_fixed_size;
        req->out.allocated = req->out.size + body_dynamic_size;