classicupgrade: fix a a bytes-like object is required, not 'str' error
authorBjörn Jacke <bj@sernet.de>
Sat, 21 Sep 2019 11:24:59 +0000 (13:24 +0200)
committerBjoern Jacke <bjacke@samba.org>
Mon, 23 Sep 2019 12:58:20 +0000 (12:58 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14136

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Björn Baumbach <bb@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Mon Sep 23 12:58:20 UTC 2019 on sn-devel-184

python/samba/upgrade.py

index 12555b7994ebe3d883b860c93284cb644df4cfa1..8511bed2868055340d0a27713f792ba15f3b68e2 100644 (file)
@@ -474,7 +474,7 @@ def upgrade_from_samba3(samba3, logger, targetdir, session_info=None,
         ldappass = secrets_db.get_ldap_bind_pw(ldapuser)
         if ldappass is None:
             raise ProvisioningError("ldapsam passdb backend detected but no LDAP Bind PW found in secrets.tdb for user %s.  Please point this tool at the secrets.tdb that was used by the previous installation.")
-        ldappass = ldappass.strip('\x00')
+        ldappass = ldappass.decode('utf-8').strip('\x00')
         ldap = True
     else:
         ldapuser = None