tests/dns_forwarder: Fail out with an assertion instead OOB error
authorGarming Sam <garming@samba.org>
Thu, 9 Jun 2016 01:52:38 +0000 (03:52 +0200)
committerGarming Sam <garming@samba.org>
Tue, 6 Sep 2016 13:41:54 +0000 (15:41 +0200)
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Sep  6 15:41:54 CEST 2016 on sn-devel-144

python/samba/tests/dns_forwarder.py

index bef21f6bdaf682efabf89b875e6a35d79d6a5f81..51a86198b545ac5d12c25f97cc97357412ad02cc 100644 (file)
@@ -466,8 +466,9 @@ class TestDnsForwarding(DNSTest):
         try:
             data = ad.recv(0xffff + 2, 0)
             data = ndr.ndr_unpack(dns.name_packet, data)
-            self.assertEqual('forwarder1', data.answers[0].rdata)
             self.assert_dns_rcode_equals(data, dns.DNS_RCODE_OK)
+            self.assertEqual(len(data.answers), 1)
+            self.assertEqual('forwarder1', data.answers[0].rdata)
         except socket.timeout:
             self.fail("DNS server is too slow (timeout %s)" % timeout)