s4-dsdb: Remove double-free in update_keytab module
authorAndrew Bartlett <abartlet@samba.org>
Mon, 27 Aug 2012 09:46:11 +0000 (19:46 +1000)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 27 Aug 2012 21:57:29 +0000 (07:57 +1000)
source4/dsdb/samdb/ldb_modules/update_keytab.c

index f07d9b2aadf280bce36d37632798d2daa65153bf..bec4a83abfcd338711c1db95374267101b12d13d 100644 (file)
@@ -109,14 +109,12 @@ static int add_modified(struct ldb_module *module, struct ldb_dn *dn, bool do_de
        if (res->count != 1) {
                /* if it's not a kerberosSecret then we don't have anything to update */
                talloc_free(res);
-               talloc_free(filter);
                return LDB_SUCCESS;
        }
 
        item = talloc(data->changed_dns? (void *)data->changed_dns: (void *)data, struct dn_list);
        if (!item) {
                talloc_free(res);
-               talloc_free(filter);
                return ldb_oom(ldb);
        }