nfs4_acls: Change type of smbacl4_substitute_simple to void
authorChristof Schmitt <cs@samba.org>
Wed, 19 Jun 2019 20:42:19 +0000 (13:42 -0700)
committerChristof Schmitt <cs@samba.org>
Tue, 23 Jul 2019 18:27:28 +0000 (18:27 +0000)
The function always returned true and the return code was never checked,
so simply change to void.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/modules/nfs4_acls.c

index 974f72c22236dc519949a4a6edda7d5af9de0f4f..bec7cc390d39f9321ccec4608a5a5d79268ba3c9 100644 (file)
@@ -902,14 +902,11 @@ static void smbacl4_substitute_special(struct SMB4ACL_T *acl,
                        DEBUG(10,("replaced with special group ace\n"));
                }
        }
-       return true; /* OK */
 }
 
-static int smbacl4_substitute_simple(
-       struct SMB4ACL_T *acl,
-       uid_t ownerUID,
-       gid_t ownerGID
-)
+static void smbacl4_substitute_simple(struct SMB4ACL_T *acl,
+                                     uid_t ownerUID,
+                                     gid_t ownerGID)
 {
        struct SMB4ACE_T *aceint;
 
@@ -939,7 +936,6 @@ static int smbacl4_substitute_simple(
                        DEBUG(10,("replaced with special group ace\n"));
                }
        }
-       return true; /* OK */
 }
 
 static struct SMB4ACL_T *smbacl4_win2nfs4(