s4-dsdb: add a comment on the use of ldb_rename()

We need to use ldb_rename() and not dsdb_module_rename() here as we
need the rename to be processed by the current module

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 7488a1bee94b4f5e1f72b018c846ca6f8ac69a6e..dadaf32f805deebac95dc69b25509f0fc9631e8a 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -2078,6 +2078,9 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
                ldb_debug(ldb, LDB_DEBUG_TRACE, "replmd_replicated_request rename %s => %s\n",
                          ldb_dn_get_linearized(ar->search_msg->dn),
                          ldb_dn_get_linearized(msg->dn));
+               /* we can't use dsdb_module_rename() here as we need
+                  the rename call to be intercepted by this module, to
+                  allow it to process linked attribute changes */
                if (ldb_rename(ldb, ar->search_msg->dn, msg->dn) != LDB_SUCCESS) {
                        ldb_debug(ldb, LDB_DEBUG_FATAL, "replmd_replicated_request rename %s => %s failed - %s\n",
                                  ldb_dn_get_linearized(ar->search_msg->dn),