s3:util: fix usage of popt_burn_cmdline_password()

We should only call popt_burn_cmdline_password() after poptFreeContext(),
otherwise we remove the password to early.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c
index d22e2f3bac08562064011421c483c2bab6d41f83..da190ddda17743c61a9964523640f6858050636d 100644 (file)
--- a/source3/utils/smbcacls.c
+++ b/source3/utils/smbcacls.c
@@ -1371,7 +1371,6 @@ static struct cli_state *connect_one(struct user_auth_info *auth_info,
        popt_common_set_auth_info(auth_info);
 
        pc = poptGetContext("smbcacls", argc, argv, long_options, 0);
-       popt_burn_cmdline_password(argc, argv);
 
        poptSetOtherOptionHelp(pc, "//server1/share1 filename\nACLs look like: "
                "'ACL:user:[ALLOWED|DENIED]/flags/permissions'");

diff --git a/source3/utils/smbcquotas.c b/source3/utils/smbcquotas.c
index d248bbe1ebf4b8ec410854053934ca926360e3e4..7363d6b4a30aea648892b6ecbd238bccabecf510 100644 (file)
--- a/source3/utils/smbcquotas.c
+++ b/source3/utils/smbcquotas.c
@@ -608,7 +608,6 @@ FSQFLAGS:QUOTA_ENABLED/DENY_DISK/LOG_SOFTLIMIT/LOG_HARD_LIMIT", "SETSTRING" },
        popt_common_set_auth_info(smbcquotas_auth_info);
 
        pc = poptGetContext("smbcquotas", argc, argv, long_options, 0);
-       popt_burn_cmdline_password(argc, argv);
 
        poptSetOtherOptionHelp(pc, "//server1/share1");