Qt: remove leak from PathChooserDelegate (found by clang).
authorDario Lombardo <lomato@gmail.com>
Thu, 18 Jan 2018 17:29:24 +0000 (18:29 +0100)
committerAlexis La Goutte <alexis.lagoutte@gmail.com>
Fri, 19 Jan 2018 14:53:17 +0000 (14:53 +0000)
Change-Id: I71d73c8464450f8cbc655f8f99f54bd34eddd344
Reviewed-on: https://code.wireshark.org/review/25374
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
ui/qt/models/path_chooser_delegate.cpp

index 8538c75ea934d5018c7babce9729f5d6fb1493be..240a41670984e549b09c7376918a325b95479bbc 100644 (file)
@@ -93,7 +93,8 @@ void PathChooserDelegate::browse_button_clicked()
         break;
     }
 
-    QString file_name = QFileDialog::getOpenFileName(new QWidget(), tr("Open Pipe"), open_dir);
+    QWidget * qw = new QWidget();
+    QString file_name = QFileDialog::getOpenFileName(qw, tr("Open Pipe"), open_dir);
     if ( !file_name.isEmpty() )
     {
         QWidget * parent = ((QPushButton *)sender())->parentWidget();
@@ -102,9 +103,9 @@ void PathChooserDelegate::browse_button_clicked()
         {
             lineEdit->setText(file_name);
             emit commitData(parent);
-
         }
     }
+    delete(qw);
 }
 
 void PathChooserDelegate::setEditorData(QWidget *editor, const QModelIndex &idx) const