OSTIP: fix typo found by PVS Studio (V519)
authorAlexis La Goutte <alexis.lagoutte@gmail.com>
Wed, 2 Dec 2015 08:19:41 +0000 (09:19 +0100)
committerMichael Mann <mmann78@netscape.net>
Wed, 2 Dec 2015 12:41:09 +0000 (12:41 +0000)
The 'pinfo->clnp_dstref' variable is assigned values twice successively

Change-Id: I02b8ae54728f88c2173b4522d436bd2f7b1b7bc0
Reviewed-on: https://code.wireshark.org/review/12365
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
epan/dissectors/packet-ositp.c

index 7da6b4b1d1296f1e24bb07e4f21fe7996133188d..5d56fd6c9f8aee70600506495aaac765325344c8 100644 (file)
@@ -1641,7 +1641,7 @@ static int ositp_decode_DC(tvbuff_t *tvb, int offset, guint8 li, guint8 tpdu,
   dst_ref = tvb_get_ntohs(tvb, offset + P_DST_REF);
   src_ref = tvb_get_ntohs(tvb, offset + P_SRC_REF);
   pinfo->clnp_dstref = dst_ref;
-  pinfo->clnp_dstref = src_ref;
+  pinfo->clnp_srcref = src_ref;
 
   col_append_fstr(pinfo->cinfo, COL_INFO,
                   "DC TPDU src-ref: 0x%04x dst-ref: 0x%04x", src_ref, dst_ref);