s4:kdc: Remove unused parameter
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 4 Apr 2023 00:54:08 +0000 (12:54 +1200)
committerAndreas Schneider <asn@cryptomilk.org>
Wed, 12 Apr 2023 13:52:31 +0000 (13:52 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/kdc/db-glue.c
source4/kdc/mit_samba.c
source4/kdc/pac-glue.c
source4/kdc/pac-glue.h

index f80334db1fda54db0f329469b59c8a0937eebf05..08941b9296a4debb51903b1edbffebf3723cdb95 100644 (file)
@@ -1407,7 +1407,7 @@ static krb5_error_code samba_kdc_message2entry(krb5_context context,
                 * and computers should never be members of Protected Users, or
                 * they may fail to authenticate.
                 */
-               status = samba_kdc_get_user_info_from_db(mem_ctx, p, msg, &user_info_dc);
+               status = samba_kdc_get_user_info_from_db(p, msg, &user_info_dc);
                if (!NT_STATUS_IS_OK(status)) {
                        ret = EINVAL;
                        goto out;
index a1615063258bcea9d0a9b1d5ebc2178651599aef..a2e2a794a036d9cf6448238ddfbffdad5a721a0d 100644 (file)
@@ -1064,8 +1064,7 @@ int mit_samba_kpasswd_change_password(struct mit_samba_context *ctx,
                return ENOMEM;
        }
 
-       status = samba_kdc_get_user_info_from_db(tmp_ctx,
-                                                p,
+       status = samba_kdc_get_user_info_from_db(p,
                                                 p->msg,
                                                 &user_info_dc);
        if (!NT_STATUS_IS_OK(status)) {
index 5448207cad0eb6a57518fb6d379248aefe9b4489..5e7e87a54fe95d6e14fe76fe97d2537ef875d3ed 100644 (file)
@@ -1203,8 +1203,7 @@ static NTSTATUS samba_add_compounded_auth(TALLOC_CTX *mem_ctx,
  * structure. If the resulting structure is not talloc_free()d, it will be
  * reused on future calls to this function.
  */
-NTSTATUS samba_kdc_get_user_info_from_db(TALLOC_CTX *mem_ctx,
-                                         struct samba_kdc_entry *skdc_entry,
+NTSTATUS samba_kdc_get_user_info_from_db(struct samba_kdc_entry *skdc_entry,
                                          const struct ldb_message *msg,
                                          const struct auth_user_info_dc **user_info_dc)
 {
@@ -1422,7 +1421,7 @@ NTSTATUS samba_kdc_get_user_info_dc(TALLOC_CTX *mem_ctx,
        NTSTATUS nt_status;
        const struct auth_user_info_dc *user_info_dc = NULL;
 
-       nt_status = samba_kdc_get_user_info_from_db(mem_ctx, skdc_entry, skdc_entry->msg, &user_info_dc);
+       nt_status = samba_kdc_get_user_info_from_db(skdc_entry, skdc_entry->msg, &user_info_dc);
        if (!NT_STATUS_IS_OK(nt_status)) {
                DBG_ERR("Getting user info for PAC failed: %s\n",
                        nt_errstr(nt_status));
@@ -2317,7 +2316,7 @@ krb5_error_code samba_kdc_verify_pac(TALLOC_CTX *mem_ctx,
                        goto done;
                }
 
-               nt_status = samba_kdc_get_user_info_from_db(mem_ctx, client, client->msg, &user_info_dc);
+               nt_status = samba_kdc_get_user_info_from_db(client, client->msg, &user_info_dc);
                if (!NT_STATUS_IS_OK(nt_status)) {
                        DBG_ERR("Getting user info for PAC failed: %s\n",
                                nt_errstr(nt_status));
index b0f02ac230c1717ff647cd9fa192cb742ab90af0..f6fe6f5974c14e239c472537b480dce0ec6a35d7 100644 (file)
@@ -77,8 +77,7 @@ int samba_krbtgt_is_in_db(struct samba_kdc_entry *skdc_entry,
                          bool *is_in_db,
                          bool *is_trusted);
 
-NTSTATUS samba_kdc_get_user_info_from_db(TALLOC_CTX *mem_ctx,
-                                        struct samba_kdc_entry *skdc_entry,
+NTSTATUS samba_kdc_get_user_info_from_db(struct samba_kdc_entry *skdc_entry,
                                         const struct ldb_message *msg,
                                         const struct auth_user_info_dc **user_info_dc);