r19072: Fix a potential NULL dereference. Simo/Tridge, not merging yet to 4_0, I'd

like you to comment.

Volker
(This used to be commit ba18c58f1fb618447ba39bae6ef8f4e6c00c4d32)

diff --git a/source3/lib/ldb/common/ldb_utf8.c b/source3/lib/ldb/common/ldb_utf8.c
index d2d12b8f51ac2498e0961272c6bf8fe49e42cd57..86ed40535a9c1756ded80735064439c9f21e72f0 100644 (file)
--- a/source3/lib/ldb/common/ldb_utf8.c
+++ b/source3/lib/ldb/common/ldb_utf8.c
@@ -126,7 +126,7 @@ char *ldb_attr_casefold(void *mem_ctx, const char *s)
 {
        int i;
        char *ret = talloc_strdup(mem_ctx, s);
-       if (!s) {
+       if (!ret) {
                errno = ENOMEM;
                return NULL;
        }