First part of bugfix for #5933

Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().

Jeremy, please check!

diff --git a/source3/smbd/password.c b/source3/smbd/password.c
index 68e134a0d6532c51a73535ee818b824b1609d0b9..d729c2e77b13ffca665c47559aef7eb2255a4618 100644 (file)
--- a/source3/smbd/password.c
+++ b/source3/smbd/password.c
@@ -281,9 +281,6 @@ int register_existing_vuid(uint16 vuid,
                "and will be vuid %u\n", (int)vuser->server_info->utok.uid,
                 vuser->server_info->unix_name, vuser->vuid));
 
-       next_vuid++;
-       num_validated_vuids++;
-
        if (!session_claim(vuser)) {
                DEBUG(1, ("register_existing_vuid: Failed to claim session "
                        "for vuid=%d\n",