Put in a comment asking about the music going over the connection - we
authorGuy Harris <guy@alum.mit.edu>
Fri, 5 Aug 2005 23:18:05 +0000 (23:18 -0000)
committerGuy Harris <guy@alum.mit.edu>
Fri, 5 Aug 2005 23:18:05 +0000 (23:18 -0000)
shouldn't try to parse it as DAAP.

svn path=/trunk/; revision=15231

epan/dissectors/packet-daap.c

index 9cc5db15420745188a3ac370e2dc69c4663085de..4e405661871f17507c296f52769d153f42ae8434 100644 (file)
@@ -146,12 +146,13 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
    proto_tree *daap_tree;
    int offset = 0;
    gboolean is_request = (pinfo->destport == TCP_PORT_DAAP);
-   
-   
+
    if (check_col(pinfo->cinfo, COL_PROTOCOL)) 
       col_set_str(pinfo->cinfo, COL_PROTOCOL, "DAAP");
-   
-   
+
+   /*
+    * XXX - what about the music itself?  Check for bogus tag values?
+    */
    if (check_col(pinfo->cinfo, COL_INFO)) {
       if (is_request) {
         col_add_str(pinfo->cinfo, COL_INFO, "DAAP Request");
@@ -165,8 +166,6 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
       }
    }
 
-   
-   
    if (tree) {
       ti = proto_tree_add_item(tree, proto_daap, tvb, 0, -1, FALSE);
       daap_tree = proto_item_add_subtree(ti, ett_daap);