CVE-2020-25720 s4-acl: Test Create Child permission should not allow full write to...
authorNadezhda Ivanova <nivanova@symas.com>
Mon, 25 Oct 2021 08:34:57 +0000 (11:34 +0300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 16 Sep 2022 02:32:36 +0000 (02:32 +0000)
commitc2761a47fd12cc2a79a02707ed9d778e496b1fd4
treef6a007837df65b16d73cc118b728eef4abc7e58c
parent2563f85237bd4260b7b527f3695f27da4cc61a74
CVE-2020-25720 s4-acl: Test Create Child permission should not allow full write to all attributes

Up to now, the rights to modify an attribute were not checked during an LDAP
add operation. This means that even if a user has no right to modify
an attribute, they can still specify any value during object creation,
and the validated writes were not checked.
This patch includes tests for the proposed change of behavior.
test_add_c3 and c4 pass, because mandatory attributes can still be
set, and in the old behavior SD permissions were irrelevant

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14810

Pair-Programmed-With: Joseph Sutton <josephsutton@catalyst.net.nz>

Signed-off-by: Nadezhda Ivanova <nivanova@symas.com>
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
selftest/knownfail.d/bug-14810 [new file with mode: 0644]
source4/dsdb/tests/python/acl.py