Fix some cases where we're shifting a signed 1 left.
authorGuy Harris <guy@alum.mit.edu>
Thu, 30 Apr 2015 22:21:00 +0000 (15:21 -0700)
committerGuy Harris <guy@alum.mit.edu>
Thu, 30 Apr 2015 22:22:59 +0000 (22:22 +0000)
commit9fba5f0764678cfed4b7ff2a41fdcb0babcdbf55
tree0515e84e39049ba809ab2c1e8c1be4e6964a464a
parentd2b02eaf591145f40eaa65d6b50908e47d7c4484
Fix some cases where we're shifting a signed 1 left.

Shift 1U instead, to make sure it's unsigned; the result of, for
example, the result of shifting a signed value left is undefined if the
value times 2^{shift count} doesn't fit in the *signed* type of the
shifted value.  That means, in particular, that the result of shifting 1
left by {number of bits in an int - 1} is undefined.  (In *practice*,
it'll probably be -2^32, with the bit you want set, but that's not
guaranteed, and GCC 5.1 seems not to like it.)

Change-Id: I0d27565c382a04ceda9eec65f45a430ceb74cf53
Reviewed-on: https://code.wireshark.org/review/8255
Reviewed-by: Guy Harris <guy@alum.mit.edu>
epan/dissectors/packet-afp.c
epan/dissectors/packet-ceph.c
epan/dissectors/packet-fcels.c
epan/dissectors/packet-netperfmeter.c
epan/dissectors/packet-reload-framing.c
epan/dissectors/packet-rsvp.c
epan/dissectors/packet-rtps.c
epan/req_resp_hdrs.c
mkcap.c
plugins/wimaxasncp/packet-wimaxasncp.c
wiretap/k12.c