the ctdb structure must make its own copy of the ->address field and not just
authorRonnie Sahlberg <sahlberg@samba.org>
Tue, 19 Feb 2008 03:35:15 +0000 (14:35 +1100)
committerRonnie Sahlberg <sahlberg@samba.org>
Tue, 19 Feb 2008 03:35:15 +0000 (14:35 +1100)
commit87b38e01b2f27314a8283b7fd079e5348d2e97fd
tree1dd49efd28718bc7adb103e71f4468cf75011e2a
parentbef60e82001c8398be57ea9a5c69cffb5cb921cb
the ctdb structure must make its own copy of the ->address field and not just
copy the content of the nodes structure.

this ctdb_address structure contains a pointer which is talloced hanging off the structure itself.
If we copy the content of this structure as we did in assigning to ctdb->address from nodes[i]
then if we talloc_free() the node structure we end up with a wild pointer in ctdb->address

(This used to be ctdb commit 644a7248548260d37df432979b129797750907f4)
ctdb/tcp/tcp_connect.c