git.samba.org / martins / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: eeb4089) | patch
dsdb group audit: align dn_compare with memcmp
authorGary Lockyer <gary@catalyst.net.nz>
Wed, 24 Oct 2018 21:52:27 +0000 (10:52 +1300)
committerStefan Metzmacher <metze@samba.org>
Tue, 30 Oct 2018 15:40:13 +0000 (16:40 +0100)
commit8420a4d0fddd71af608635a707ef20f37fa9b627
tree5489d1ef28e60397553dad8ab007481f6c995352tree
parenteeb4089dafc45277d8af19073ef9348451c1836acommit | diff
dsdb group audit: align dn_compare with memcmp

Rename the parameter names and adjust the  return codes from dn_compare
so that:
dn_compare(a, b) =>

LESS_THAN means a is less than b.
GREATER_THAN means a is greater than b.

Thanks to metze for suggesting the correct semantics for dn_compare

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13664

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
selftest/knownfail.d/bug13664 [deleted file] blob | history
source4/dsdb/samdb/ldb_modules/group_audit.c diff | blob | history
source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c diff | blob | history
Martin's Samba development