Consistently use the "g_string_free returns a C string pointer" idiom.
authorGuy Harris <guy@alum.mit.edu>
Tue, 13 Jan 2015 23:13:40 +0000 (15:13 -0800)
committerGuy Harris <guy@alum.mit.edu>
Tue, 13 Jan 2015 23:14:13 +0000 (23:14 +0000)
commit63a3d043e3f14eebb0798a250d9aecdc8e89dfb9
tree69a58dd4cadfc7f98669cba229e76fa8c60e0761
parent9f5e4fb7a51741a286ce5bc92a6f335ed58587a2
Consistently use the "g_string_free returns a C string pointer" idiom.

g_string_free(str, FALSE) frees the GString container but not the
underlying g_malloc()ed string; instead, it returns a pointer to the
g_malloc()ed string.

Fix those places that didn't already get the string pointer from
g_string_free() to do so rather than manually extracting the string
themselves.

And fix one place that didn't even need to use a string - it was just
scanning a C string without even modifying it.

Change-Id: Ibbf4872bf5b9935b9907f539b6edb1013f3053a5
Reviewed-on: https://code.wireshark.org/review/6532
Reviewed-by: Guy Harris <guy@alum.mit.edu>
25 files changed:
capchild/capture_sync.c
caputils/airpcap_loader.c
echld/child.c
echld/common.c
echld/dispatcher.c
echld/parent.c
echld_test.c
epan/conversation_table.c
epan/dfilter/dfilter-macro.c
epan/dissectors/packet-xml.c
epan/geoip_db.c
epan/oids.c
epan/radius_dict.l
plugins/mate/mate_util.c
plugins/wimaxasncp/wimaxasncp_dict.l
ui/gtk/file_import_dlg.c
ui/gtk/main_menubar.c
ui/gtk/packet_win.c
ui/gtk/sctp_assoc_analyse.c
ui/gtk/sctp_stat_dlg.c
ui/help_url.c
ui/ssl_key_export.c
ui/tap_export_pdu.c
ui/voip_calls.c
wsutil/str_util.c