af_packet: do not call packet_read_pending() from tpacket_destruct_skb()
authorEric Dumazet <edumazet@google.com>
Wed, 15 May 2024 16:33:58 +0000 (16:33 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 May 2024 02:38:05 +0000 (19:38 -0700)
commit581073f626e387d3e7eed55c48c8495584ead7ba
tree4ef79fb695b5a7965710ba045979db1ae9cc4158
parentfa033def4171d2e4e29d5e3714fb2a5b1fc077e8
af_packet: do not call packet_read_pending() from tpacket_destruct_skb()

trafgen performance considerably sank on hosts with many cores
after the blamed commit.

packet_read_pending() is very expensive, and calling it
in af_packet fast path defeats Daniel intent in commit
b013840810c2 ("packet: use percpu mmap tx frame pending refcount")

tpacket_destruct_skb() makes room for one packet, we can immediately
wakeup a producer, no need to completely drain the tx ring.

Fixes: 89ed5b519004 ("af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20240515163358.4105915-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/packet/af_packet.c