dsdb: Ensure that a DN (now) pointing at a deleted object counts for objectclass...
authorAndrew Bartlett <abartlet@samba.org>
Wed, 12 Sep 2018 19:48:04 +0000 (14:48 -0500)
committerDouglas Bagnall <dbagnall@samba.org>
Fri, 12 Oct 2018 02:16:22 +0000 (04:16 +0200)
commit4092b369aeeb7058d78b8d6f41dbbc6d69203ecc
treeddf57c07b65efe8760c0aaea9162a63694c631ff
parentdec3eda1f74f5bf7ea91c1be3d5dfd832e9672b9
dsdb: Ensure that a DN (now) pointing at a deleted object counts for objectclass-based MUST

Add the 'reveal_internals' controls when performing objectclass-based
checks of mandatory attributes. This prevents the extended_dn DSDB
module from suppressing attributes that point to deleted (i.e.
non-existent/expunged) objects.

This ensures that, when modifying an object (and often not even
touching the mandatory attribute) that the fact that an attribute is a
DN, and the DN target is deleted, that the schema check will still pass.

Otherwise a fromServer pointing at a dead server can cause failures,
i.e. you can't modify the affected object at all, because the DSDB
thinks a mandatory attribute is missing.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13621

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
selftest/knownfail.d/attr_from_server [deleted file]
source4/dsdb/samdb/ldb_modules/objectclass_attrs.c